Issue 594123002: Update the homepage URL for the generated packages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 594123002: Update the homepage URL for the generated packages (Closed)

Created:
6 years, 3 months ago by Søren Gjesse

Modified:
6 years, 3 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/googleapis.git@master

Visibility:
Public.

More Reviews

Description

Update the homepage URL for the generated packages R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/gcloud/commit/2d28bb7328b7be597948bd6105e567d3551a2a65

Patch Set 2 : Addressed review comments (removed generated content) #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	config.yaml	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/594123002/diff/1/config.yaml File config.yaml (right): https://codereview.chromium.org/594123002/diff/1/config.yaml#newcode3 config.yaml:3: version: 0.1.2 Make it 0.2.0 -- my next ...

6 years, 3 months ago (2014-09-23 12:12:45 UTC) #2

Søren Gjesse

Just update the config.yaml, as a new push is pending. https://codereview.chromium.org/594123002/diff/1/generated/googleapis/lib/src/common_internal.dart File generated/googleapis/lib/src/common_internal.dart (right): https://codereview.chromium.org/594123002/diff/1/generated/googleapis/lib/src/common_internal.dart#newcode12 ...

6 years, 3 months ago (2014-09-23 12:41:01 UTC) #3

Søren Gjesse

6 years, 3 months ago (2014-09-23 12:41:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 2d28bb7 (presubmit successful).

Expand Messages | Collapse Messages

Issue 594123002: Update the homepage URL for the generated packages (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments (removed generated content) #

Messages