Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 59393003: Always mark stdout and stderr as blocking on exit. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Always mark stdout and stderr as blocking on exit. This is required by some shell systems, such as Emacs. BUG=https://code.google.com/p/dart/issues/detail?id=14301 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M runtime/bin/main.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/bin/platform.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/process.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-11-05 11:24:15 UTC) #1
Søren Gjesse
lgtm
7 years, 1 month ago (2013-11-05 11:50:41 UTC) #2
Anders Johnsen
7 years, 1 month ago (2013-11-05 11:58:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698