Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 593383002: Give http_multi_server a more accurate SDK bound. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Give http_multi_server a more accurate SDK bound. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=40620

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/http_multi_server/pubspec.yaml View 2 chunks +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
6 years, 3 months ago (2014-09-24 00:51:30 UTC) #1
nweiz
Committed patchset #1 (id:1) manually as 40620 (presubmit successful).
6 years, 3 months ago (2014-09-24 00:51:50 UTC) #2
Bob Nystrom
lgtm
6 years, 3 months ago (2014-09-24 19:45:21 UTC) #3
Anders Johnsen
DBC https://codereview.chromium.org/593383002/diff/1/pkg/http_multi_server/pubspec.yaml File pkg/http_multi_server/pubspec.yaml (right): https://codereview.chromium.org/593383002/diff/1/pkg/http_multi_server/pubspec.yaml#newcode11 pkg/http_multi_server/pubspec.yaml:11: sdk: ">=1.7.0-edge.40587 <2.0.0" Isn't it called 'be'? If ...
6 years, 2 months ago (2014-09-25 07:39:50 UTC) #5
nweiz
6 years, 2 months ago (2014-09-25 20:37:03 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/593383002/diff/1/pkg/http_multi_server/pubspe...
File pkg/http_multi_server/pubspec.yaml (right):

https://codereview.chromium.org/593383002/diff/1/pkg/http_multi_server/pubspe...
pkg/http_multi_server/pubspec.yaml:11: sdk: ">=1.7.0-edge.40587 <2.0.0"
On 2014/09/25 07:39:50, Anders Johnsen wrote:
> Isn't it called 'be'? If not, dev < edge, which would be very odd.

No, "edge" is correct. It's important that it come after "dev"; otherwise, it's
declaring compatibility with all dev SDKs for the same stable version. It would
be bad if this package were picked up by 1.7.0-dev.1, for example.

Powered by Google App Engine
This is Rietveld 408576698