Issue 59283007: List scripts in library and display script source

Issue 59283007: List scripts in library and display script source (Closed)

Created:
7 years, 1 month ago by Cutch

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

List scripts in library and display script source BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30732

Patch Set 5 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2911 lines, -1345 lines)			Patch
M	runtime/bin/vmservice/client/build.dart	View	1 2 3 4	1 chunk	+6 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3 4	6 chunks	+45 lines, -4 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart	View	1 2 3	2 chunks	+12 lines, -8 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2 3 4	390 chunks	+2612 lines, -1308 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/observatory.dart	View	2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/observatory_elements.dart	View	2 3	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/observatory_elements.html	View	2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/isolate.dart	View	2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart	View	2 3	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart	View	2 3	5 chunks	+29 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart	View	2 3	1 chunk	+39 lines, -3 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/observatory/script_source.dart	View	1 2 3 4	1 chunk	+42 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html	View	1 2 3 4	2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html	View	2 3	2 chunks	+5 lines, -0 lines	0 comments	Download
A +	runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.dart	View	1 2 3	1 chunk	+5 lines, -6 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/observatory_elements/script_view.html	View	2 3	1 chunk	+10 lines, -0 lines	0 comments	Download
A +	runtime/bin/vmservice/client/lib/src/observatory_elements/source_view.dart	View	1 2 3	1 chunk	+6 lines, -6 lines	0 comments	Download
A	runtime/bin/vmservice/client/lib/src/observatory_elements/source_view.html	View	2 3	1 chunk	+22 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/web/index.html	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	3 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/59283007/diff/400001/runtime/bin/vmservice/client/lib/src/observatory/script_source.dart File runtime/bin/vmservice/client/lib/src/observatory/script_source.dart (right): https://codereview.chromium.org/59283007/diff/400001/runtime/bin/vmservice/client/lib/src/observatory/script_source.dart#newcode15 runtime/bin/vmservice/client/lib/src/observatory/script_source.dart:15: paddedLine = '0$paddedLine'; Please pad with spaces.

7 years, 1 month ago (2013-11-19 23:24:04 UTC) #2

Cutch

https://codereview.chromium.org/59283007/diff/400001/runtime/bin/vmservice/client/lib/src/observatory/script_source.dart File runtime/bin/vmservice/client/lib/src/observatory/script_source.dart (right): https://codereview.chromium.org/59283007/diff/400001/runtime/bin/vmservice/client/lib/src/observatory/script_source.dart#newcode15 runtime/bin/vmservice/client/lib/src/observatory/script_source.dart:15: paddedLine = '0$paddedLine'; On 2013/11/19 23:24:05, Ivan Posva wrote: ...

7 years ago (2013-11-27 19:54:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r30732 (presubmit successful).

Expand Messages | Collapse Messages