'Convert Method to Getter' refactoring implementation.

'Convert Method to Getter' refactoring implementation.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=40541

[Brian Wilkerson, 2014-09-22 14:04:07]

LGTM

https://codereview.chromium.org/592643002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/592643002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:76:
if (element is MethodElement) {
It's kind of strange to have an empty block on an 'if' statement. Consider
re-writing to

if (element is FunctionElement) {
  return ...
} else if (element is! MethodElement) {
  return ...
}

[scheglov, 2014-09-22 14:53:26]

Committed patchset #1 (id:1) manually as 40541 (presubmit successful).

[scheglov, 2014-09-22 14:53:45]

https://codereview.chromium.org/592643002/diff/1/pkg/analysis_server/lib/src/...
File
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart
(right):

https://codereview.chromium.org/592643002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart:76:
if (element is MethodElement) {
On 2014/09/22 14:04:07, Brian Wilkerson wrote:
> It's kind of strange to have an empty block on an 'if' statement. Consider
> re-writing to
> 
> if (element is FunctionElement) {
>   return ...
> } else if (element is! MethodElement) {
>   return ...
> }

Done.