Issue 59223005: Properly report pub.dartlang.org API errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59223005: Properly report pub.dartlang.org API errors. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

Properly report pub.dartlang.org API errors. There were two issues here: first, there was leftover debugging code that was printing stack traces for all unsuccessful HTTP responses. Second, JSON-encoded errors from the server were considered "unexpected errors", so their stack traces were printed along with some scary text. This CL fixes both issues. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=30077

Patch Set 1 #

Created: 7 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+1 line, -3 lines)
	M	sdk/lib/_internal/pub/lib/src/http.dart	View	2 chunks	+1 line, -3 lines	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 1 month ago (2013-11-07 22:18:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30077 (presubmit successful).

Expand Messages | Collapse Messages