Issue 59213003: Rename remoteHost to remoteAddress on *Socket.

Issue 59213003: Rename remoteHost to remoteAddress on *Socket. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename remoteHost to remoteAddress on *Socket. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29904

Patch Set 2 : Added mac/win/android versions. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -89 lines)			Patch
M	runtime/bin/socket.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket.cc	View	1	1 chunk	+15 lines, -4 lines	0 comments	Download
M	runtime/bin/socket_android.cc	View	1	2 chunks	+3 lines, -16 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View		2 chunks	+3 lines, -16 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1	2 chunks	+3 lines, -16 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View	1	2 chunks	+3 lines, -16 lines	0 comments	Download
M	sdk/lib/io/http.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/http_impl.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/socket.dart	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/standalone/io/http_connection_info_test.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/standalone/io/socket_info_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM - this is just much better. https://codereview.chromium.org/59213003/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/59213003/diff/1/runtime/bin/socket.cc#newcode248 runtime/bin/socket.cc:248: Dart_Handle data ...

7 years, 1 month ago (2013-11-05 13:14:05 UTC) #1

Anders Johnsen

PTAL, added other versions. https://codereview.chromium.org/59213003/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/59213003/diff/1/runtime/bin/socket.cc#newcode248 runtime/bin/socket.cc:248: Dart_Handle data = Dart_NewList(data_length); On ...

7 years, 1 month ago (2013-11-05 13:19:43 UTC) #2

Anders Johnsen

7 years, 1 month ago (2013-11-05 13:25:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29904 (presubmit successful).

Expand Messages | Collapse Messages