Issue 59143006: Work around a flake in the Mac OS watcher test on the bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59143006: Work around a flake in the Mac OS watcher test on the bots. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Work around a flake in the Mac OS watcher test on the bots. Issues 14373 and 14793 were tag-teaming to cause no_subscription_test to fail for the Mac OS watcher occasionally. This also marks directory_watcher/mac_os_test as timing out, apparently due to issue 14943. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30174

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -11 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/watcher/test/no_subscription/shared.dart	View	2 chunks	+12 lines, -4 lines	0 comments	Download
M	pkg/watcher/test/utils.dart	View	3 chunks	+11 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 1 month ago (2013-11-11 21:26:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30174 (presubmit successful).

Expand Messages | Collapse Messages