Issue 590123002: Revert "Per isolate package root."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 590123002: Revert "Per isolate package root." (Closed)

Created:
6 years, 3 months ago by Anders Johnsen

Modified:
6 years, 3 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Per isolate package root." Revert "Fix test in checked mode." The Dartium branch is locked atm, making it impossible to land this and have green Dartium bots. BUG= Committed: https://code.google.com/p/dart/source/detail?r=40540

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -105 lines)			Patch
M	runtime/bin/isolate_data.h	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	runtime/bin/main.cc	View	8 chunks	+16 lines, -17 lines	0 comments	Download
M	runtime/include/dart_api.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	4 chunks	+3 lines, -15 lines	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	sdk/lib/isolate/isolate.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	tests/isolate/package_root_test.dart	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Anders Johnsen

6 years, 3 months ago (2014-09-22 11:13:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40540 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages