warn if inlining the same css file more than once

warn if inlining the same css file more than once

BUG= http://dartbug.com/19996
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40548

[jakemac, 2014-09-19 21:01:13]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[jakemac, 2014-09-19 21:01:14]

I was thinking about maybe aggregating these all into one message as well, but I
don't think we have a way of linking multiple assets with a single log... :(

[Siggi Cherem (dart-lang), 2014-09-19 21:13:36]

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
File pkg/polymer/lib/src/build/messages.dart (right):

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
pkg/polymer/lib/src/build/messages.dart:545: 'A css file is being inlined in
multiple places for a single entry point.',
Some ideas:
- 'is being inlined' => 'was inlined'
- 'in multiple places' => 'multiple times'
- 'for a single entrypoint' => 'in your app' (or remove)
- use the template to actually indicate the url of the actual css file

So it could look something like this:

'The css file "%-url-%" was inlined multiple times.'

Since we also have the option of putting a parameter, we could also mention here
what the line fix could look like:

  inline_stylesheets:
    %-canonical-path-%: false

if you like.

[jakemac, 2014-09-19 21:38:16]

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
File pkg/polymer/lib/src/build/messages.dart (right):

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
pkg/polymer/lib/src/build/messages.dart:545: 'A css file is being inlined in
multiple places for a single entry point.',
On 2014/09/19 21:13:36, Siggi Cherem (dart-lang) wrote:
> Some ideas:
> - 'is being inlined' => 'was inlined'
> - 'in multiple places' => 'multiple times'
> - 'for a single entrypoint' => 'in your app' (or remove)
> - use the template to actually indicate the url of the actual css file
> 
> So it could look something like this:
> 
> 'The css file "%-url-%" was inlined multiple times.'
> 
> Since we also have the option of putting a parameter, we could also mention
here
> what the line fix could look like:
> 
>   inline_stylesheets:
>     %-canonical-path-%: false
> 
> if you like.

Added in the %-url-% placeholder, but we can't put them in the details right?
(thats part of the static site).

[Siggi Cherem (dart-lang), 2014-09-19 22:11:34]

lgtm

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
File pkg/polymer/lib/src/build/messages.dart (right):

https://codereview.chromium.org/589743002/diff/1/pkg/polymer/lib/src/build/me...
pkg/polymer/lib/src/build/messages.dart:545: 'A css file is being inlined in
multiple places for a single entry point.',
On 2014/09/19 21:38:16, jakemac wrote:
> On 2014/09/19 21:13:36, Siggi Cherem (dart-lang) wrote:
> > Some ideas:
> > - 'is being inlined' => 'was inlined'
> > - 'in multiple places' => 'multiple times'
> > - 'for a single entrypoint' => 'in your app' (or remove)
> > - use the template to actually indicate the url of the actual css file
> > 
> > So it could look something like this:
> > 
> > 'The css file "%-url-%" was inlined multiple times.'
> > 
> > Since we also have the option of putting a parameter, we could also mention
> here
> > what the line fix could look like:
> > 
> >   inline_stylesheets:
> >     %-canonical-path-%: false
> > 
> > if you like.
> 
> Added in the %-url-% placeholder, but we can't put them in the details right?
> (thats part of the static site).

Ah, sorry I meant if you wanted to include some details also in the error
message, for example:

The css file %-url-% was inlined multiple times. You can disable inlining for
this url by adding the following in your pubspec:
    inline_stylesheets:
       %-canonical-path-%: false


Now that I write this down, it feels like the message is getting long and the
formatting is going to be hard, so I'm ok only mentioning the generic
instructions in the site and keeping this short like you have it.

[jakemac, 2014-09-22 16:34:14]

Committed patchset #3 (id:40001) manually as 40548 (presubmit successful).