Issue 58943002: Add missing ByteData.elementSizeInBytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 58943002: Add missing ByteData.elementSizeInBytes. (Closed)

Created:
7 years, 1 month ago by floitsch

Modified:
7 years, 1 month ago

Reviewers:
Cutch, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add missing ByteData.elementSizeInBytes. BUG= http://dartbug.com/12881 R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29918

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)			Patch
M	runtime/lib/typed_data.dart	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r29918 (presubmit successful).

7 years, 1 month ago (2013-11-05 18:04:50 UTC) #3

Ivan Posva

https://codereview.chromium.org/58943002/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): https://codereview.chromium.org/58943002/diff/1/runtime/lib/typed_data.dart#newcode3003 runtime/lib/typed_data.dart:3003: int get elementSizeInBytes { I don't think this belongs ...

7 years, 1 month ago (2013-11-05 19:15:28 UTC) #4

Ivan Posva

7 years, 1 month ago (2013-11-05 19:18:13 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/58943002/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/58943002/diff/1/runtime/lib/typed_data.dart#n...
runtime/lib/typed_data.dart:3003: int get elementSizeInBytes {
On 2013/11/05 19:15:28, Ivan Posva wrote:
> I don't think this belongs here.

Never mind, mixed up ByteBuffer and ByteData.

Expand Messages | Collapse Messages