- Avoid deep recursions when executing type tests.

- Avoid deep recursions when executing type tests.

Committed: https://code.google.com/p/dart/source/detail?r=29873

[Ivan Posva, 2013-11-05 04:44:50]

TBR

[Ivan Posva, 2013-11-05 04:45:20]

Committed patchset #1 manually as r29873 (presubmit successful).

[Ivan Posva, 2013-11-05 04:48:29]

This avoids running out of stack space on the Mac when running on the buildbot.

-Ivan

https://codereview.chromium.org/58923002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/58923002/diff/1/runtime/vm/object.cc#newcode2751
runtime/vm/object.cc:2751: ASSERT(!thsi.IsVoidClass());
The contents of this loop is what was being done as part of Class::TypeTest
previously. The only difference is the use of thsi instead of the implicit
receiver, as well as the avoidance of recursion.

[regis, 2013-11-05 18:17:40]

https://codereview.chromium.org/58923002/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/58923002/diff/1/runtime/vm/object.cc#newcode2740
runtime/vm/object.cc:2740: bool Class::TypeTestNonRecursive(
Why do you need a new function that is forwarded to from the old one?

Also 'thsi' is a terrible name :-)

I would keep the old function and declare a local cls instead of thsi:

Class& cls = Class::Handle(raw());

You just need to rename the local cls below to super_cls.