Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 58903013: pkg/unittest: remove overriding stack variable (Closed)

Created:
7 years, 1 month ago by kevmoo-old
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/unittest: remove overriding stack variable R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=30322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M pkg/unittest/lib/src/test_case.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
Without this patch, the only stackTrace that will be reported for exceptions will be those ...
7 years, 1 month ago (2013-11-15 22:44:59 UTC) #1
Bob Nystrom
LGTM!
7 years, 1 month ago (2013-11-15 22:50:19 UTC) #2
kevmoo-old
7 years, 1 month ago (2013-11-15 22:54:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698