Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 58843004: Add safety margin to timer_isolate_test.dart (Closed)

Created:
7 years, 1 month ago by floitsch
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Add safety margin to timer_isolate_test.dart Should make the test less flaky. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tests/lib/async/timer_isolate_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 1 month ago (2013-11-05 03:51:33 UTC) #1
Anders Johnsen
Ugly, but lgtm :)
7 years, 1 month ago (2013-11-05 10:22:58 UTC) #2
floitsch
7 years, 1 month ago (2013-11-05 18:20:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29921 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698