Issue 587873003: Pass isolate to BitVector constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587873003: Pass isolate to BitVector constructor. (Closed)

Created:
6 years, 3 months ago by srdjan

Modified:
6 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -50 lines)			Patch
M	runtime/vm/bit_vector.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/bit_vector_test.cc	View	5 chunks	+13 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph.cc	View	7 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	13 chunks	+22 lines, -18 lines	0 comments	Download
M	runtime/vm/flow_graph_range_analysis.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (1 generated)

srdjan

On 2014/09/19 22:40:38, hausner wrote: > LGTM. Any measurable impact? I did not see any.

6 years, 3 months ago (2014-09-19 23:14:19 UTC) #4

srdjan

6 years, 3 months ago (2014-09-19 23:14:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40528 (presubmit successful).