Issue 587553002: API proposal for the MOVE_FILE refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 587553002: API proposal for the MOVE_FILE refactoring. (Closed)

Created:
6 years, 3 months ago by scheglov

Modified:
6 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

API proposal for the MOVE_FILE refactoring. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40499

Patch Set 2 : add MoveFileOptions.java #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -26 lines)			Patch
A +	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/MoveFileOptions.java	View	1	3 chunks	+26 lines, -26 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View		1 chunk	+79 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View		1 chunk	+23 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/587553002/diff/20001/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/587553002/diff/20001/pkg/analysis_server/tool/spec/spec_input.html#newcode3283 pkg/analysis_server/tool/spec/spec_input.html:3283: The "offset" and "length" fields are ignored. "fields ...

6 years, 3 months ago (2014-09-19 13:48:22 UTC) #2

scheglov

6 years, 3 months ago (2014-09-19 16:20:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 40499 (presubmit successful).

Expand Messages | Collapse Messages

Issue 587553002: API proposal for the MOVE_FILE refactoring. (Closed)

Description

Patch Set 1 #

Patch Set 2 : add MoveFileOptions.java #

Messages