Issue 585703002: pkg/metatest: adding homepage to metatest pubspec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 585703002: pkg/metatest: adding homepage to metatest pubspec (Closed)

Created:
6 years, 3 months ago by kevmoo

Modified:
6 years, 3 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/metatest: adding homepage to metatest pubspec TBR Committed: https://code.google.com/p/dart/source/detail?r=40479

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	pkg/metatest/pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	pkg/pkg.status	View		1 chunk	+0 lines, -6 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

Committed patchset #1 (id:1) manually as 40479 (presubmit successful).

6 years, 3 months ago (2014-09-18 23:39:49 UTC) #3

nweiz

https://codereview.chromium.org/585703002/diff/1/pkg/pkg.status File pkg/pkg.status (left): https://codereview.chromium.org/585703002/diff/1/pkg/pkg.status#oldcode450 pkg/pkg.status:450: scheduled_test/test/scheduled_test/tear_down_test: Timeout Unrelated change?

6 years, 3 months ago (2014-09-18 23:41:57 UTC) #4

kevmoo

6 years, 3 months ago (2014-09-18 23:43:11 UTC) #5

Message was sent while issue was closed.

On 2014/09/18 23:41:57, nweiz wrote:
> https://codereview.chromium.org/585703002/diff/1/pkg/pkg.status
> File pkg/pkg.status (left):
> 
> https://codereview.chromium.org/585703002/diff/1/pkg/pkg.status#oldcode450
> pkg/pkg.status:450: scheduled_test/test/scheduled_test/tear_down_test: Timeout
> Unrelated change?

Crap. These are valid changes to the status file as well, but should have been
in another CL.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages