Allow sending static/top-level functions through ports and as isolate

Allow sending static/top-level functions through ports and as isolate
initialization messages.

BUG= http://dartbug.com/20992
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40535

[Lasse Reichstein Nielsen, 2014-09-19 12:50:12]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-09-19 19:52:46]

LGTM.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
File tests/isolate/function_send_test.dart (right):

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:11: void mkToplevelFunc() => (p, m) {
p.send(m); };
mkFuncToplevel
or
funcGeneratorToplevel

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:46: // Actually allowed. Identical in VM,
different, but still static, in dart2js.
If it's allowed, why is it commented?

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:51: //testSendable("callable object", new
Callable());    /// 01: ok
Why is it commented?
Especially with "/// 01: ok".

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:52: testUnsendable("callable object", new
Callable());    /// 02: ok
That looks like the same as above...

[Lasse Reichstein Nielsen, 2014-09-22 08:29:54]

Committed patchset #2 (id:20001) manually as 40535 (presubmit successful).

[Lasse Reichstein Nielsen, 2014-09-23 07:25:08]

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
File tests/isolate/function_send_test.dart (right):

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:11: void mkToplevelFunc() => (p, m) {
p.send(m); };
I'll go for createFuncToplevel.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:46: // Actually allowed. Identical in VM,
different, but still static, in dart2js.
I can't say whether it should be allowed or not, and the spec isn't helping.
I would have expected it to not work, but it turns out that it does.

I'll make the test match the current behavior and just make a comment saying
that it's unknown whether toplevel.call is equal to or identical to toplevel,
and whether it should be sendable if not identical.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:51: //testSendable("callable object", new
Callable());    /// 01: ok
Again I can't decide on whether it should be one or the other, and since the VM
will likely allow sending any object, including callable objects, and dart2js
will not, there is no clear answer.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:52: testUnsendable("callable object", new
Callable());    /// 02: ok
This one is test*Un*sendablem the one above is testSendable.

Neither is a hard requirement, so I'll just leave it out until the time when we
actually define what can be sent to which other isolates.

[Lasse Reichstein Nielsen, 2014-09-23 07:25:08]

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
File tests/isolate/function_send_test.dart (right):

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:11: void mkToplevelFunc() => (p, m) {
p.send(m); };
I'll go for createFuncToplevel.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:46: // Actually allowed. Identical in VM,
different, but still static, in dart2js.
I can't say whether it should be allowed or not, and the spec isn't helping.
I would have expected it to not work, but it turns out that it does.

I'll make the test match the current behavior and just make a comment saying
that it's unknown whether toplevel.call is equal to or identical to toplevel,
and whether it should be sendable if not identical.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:51: //testSendable("callable object", new
Callable());    /// 01: ok
Again I can't decide on whether it should be one or the other, and since the VM
will likely allow sending any object, including callable objects, and dart2js
will not, there is no clear answer.

https://codereview.chromium.org/584843003/diff/1/tests/isolate/function_send_...
tests/isolate/function_send_test.dart:52: testUnsendable("callable object", new
Callable());    /// 02: ok
This one is test*Un*sendablem the one above is testSendable.

Neither is a hard requirement, so I'll just leave it out until the time when we
actually define what can be sent to which other isolates.