Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 584813002: Avoid undefined variable in gyp files. (Closed)

Created:
6 years, 3 months ago by Bill Hesse
Modified:
6 years, 3 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1, Ivan Posva
Visibility:
Public.

Description

Avoid undefined variable in gyp files. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/gyp/configurations_xcode.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/xcode.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
6 years, 3 months ago (2014-09-19 08:30:51 UTC) #2
ricow1
lgtm
6 years, 3 months ago (2014-09-19 08:34:48 UTC) #3
Bill Hesse
6 years, 3 months ago (2014-09-19 08:36:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40490 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698