Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 584293002: Begin implementing a debugger page in Observatory. (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Begin implementing a debugger page in Observatory. In progress. For now we have a split view with the stack on top and console/controls on the bottom. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40887

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : use flexbox, basic commandline #

Total comments: 4

Patch Set 5 : more stuff #

Total comments: 1

Patch Set 6 : code review #

Patch Set 7 : improve deploy.sh #

Patch Set 8 : minor tweak #

Patch Set 9 : don't rely on core/paper #

Patch Set 10 : more better #

Patch Set 11 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19136 lines, -16134 lines) Patch
M runtime/bin/vmservice/observatory/deploy.sh View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html View 1 2 3 4 5 6 7 8 9 10 93 chunks +3153 lines, -2320 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 5 6 7 8 9 10 724 chunks +6072 lines, -5652 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html View 1 2 3 4 5 6 7 8 9 10 93 chunks +3153 lines, -2320 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 5 6 7 8 9 10 724 chunks +6072 lines, -5652 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/elements.html View 1 2 3 4 5 6 7 8 9 10 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/css/shared.css View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/debugger.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +226 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/flag_list.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/script_inset.html View 1 2 3 4 5 6 7 8 9 10 2 chunks +1 line, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/observatory/src/elements/service_view.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/build.log View 1 2 3 4 5 6 7 8 9 10 1 chunk +13 lines, -13 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/polymer/src/js/polymer/polymer.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/build.log View 1 2 3 4 5 6 7 8 9 10 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/packages/web_components/platform.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/elements.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/elements.html View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/application.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/app/page.dart View 2 chunks +35 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/css/shared.css View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart View 1 2 3 4 5 6 7 8 1 chunk +135 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/observatory/lib/src/elements/debugger.html View 1 2 3 4 5 6 7 8 9 1 chunk +226 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/flag_list.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/isolate_summary.html View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/nav_bar.html View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/object_view.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/script_inset.html View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D runtime/bin/vmservice/observatory/lib/src/elements/stack_frame.html View 1 chunk +0 lines, -42 lines 0 comments Download
D runtime/bin/vmservice/observatory/lib/src/elements/stack_trace.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/bin/vmservice/observatory/lib/src/elements/stack_trace.html View 1 chunk +0 lines, -33 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/service/object.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/web/index.html View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/web/index_devtools.html View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M runtime/bin/vmservice/resources.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
turnidge
6 years, 3 months ago (2014-09-19 21:36:36 UTC) #2
Cutch
lgtm https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart File runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart (right): https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart#newcode58 runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart:58: @published bool expand = false; // Expand by ...
6 years, 3 months ago (2014-09-22 17:36:30 UTC) #3
turnidge
https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart File runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart (right): https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart#newcode58 runtime/bin/vmservice/observatory/lib/src/elements/debugger.dart:58: @published bool expand = false; // Expand by default ...
6 years, 2 months ago (2014-09-30 18:48:48 UTC) #4
turnidge
https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.html File runtime/bin/vmservice/observatory/lib/src/elements/debugger.html (right): https://codereview.chromium.org/584293002/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/debugger.html#newcode58 runtime/bin/vmservice/observatory/lib/src/elements/debugger.html:58: <debugger-input id="debuggerInput" isolate="{{ isolate }}"> On 2014/09/22 17:36:30, Cutch ...
6 years, 2 months ago (2014-09-30 18:49:44 UTC) #5
turnidge
Could use another look -- a bunch has changed...
6 years, 2 months ago (2014-10-01 20:05:49 UTC) #6
Cutch
lgtm
6 years, 2 months ago (2014-10-01 20:09:01 UTC) #7
turnidge
6 years, 2 months ago (2014-10-02 17:34:17 UTC) #8
Message was sent while issue was closed. 
Committed patchset #11 (id:200001) manually as 40887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698