Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 583683002: Fixes for the profiler on arm64. (Closed)

Created:
6 years, 3 months ago by zra
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixes for the profiler on arm64. On arm64, in Dart code, R18(SP) is the stack pointer. In C++ code, R31(CSP) is the stack pointer. The profiler must choose the right one when performing its bounds checks. This change also fixes a bug in the InvokeDartCode stub on arm64 so that CSP is set to the Isolate's stack limit immediately, rather than a bit later. When it was set a bit later, if a profiler interrupt came in in the interim, the stack would be smashed. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40502

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -35 lines) Patch
M runtime/vm/profiler.cc View 1 8 chunks +20 lines, -9 lines 0 comments Download
M runtime/vm/signal_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/signal_handler_android.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M runtime/vm/signal_handler_linux.cc View 1 5 chunks +22 lines, -1 line 0 comments Download
M runtime/vm/signal_handler_macos.cc View 1 5 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/signal_handler_win.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 4 chunks +13 lines, -11 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
Not sure I've got the right check in the profiler to choose the right sp. ...
6 years, 3 months ago (2014-09-18 16:47:23 UTC) #2
Cutch
lgtm
6 years, 3 months ago (2014-09-18 17:21:15 UTC) #3
zra
6 years, 3 months ago (2014-09-19 16:25:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r40502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698