Issue 583583007: 1. Add user tag to the pointers traversed in the object store

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 583583007: 1. Add user tag to the pointers traversed in the object store (Closed)

Created:
6 years, 3 months ago by siva

Modified:
6 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

1. Add user tag to the pointers traversed in the object store 2. Added support for UserTag objects in a full snapshot. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40508

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -34 lines)			Patch
M	runtime/lib/profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/isolate.h	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	4 chunks	+13 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	runtime/vm/object_store.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

siva

Moved default_tag_ to isolate. current_tag_, tag_table_ and default_tag_ are now together. PTAL

6 years, 3 months ago (2014-09-19 17:00:07 UTC) #4

siva

6 years, 3 months ago (2014-09-19 18:00:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as r40508 (presubmit successful).