Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 583193008: Allow ".dart" extension in pub run. (Closed)

Created:
6 years, 3 months ago by Bob Nystrom
Modified:
6 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow ".dart" extension in pub run. BUG=https://code.google.com/p/dart/issues/detail?id=21018 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=40569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -117 lines) Patch
M sdk/lib/_internal/pub/lib/src/executable.dart View 2 chunks +8 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub/test/run/allows_dart_extension_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/executable.dart View 1 chunk +122 lines, -110 lines 0 comments Download
A + sdk/lib/_internal/pub_generated/test/run/allows_dart_extension_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
6 years, 3 months ago (2014-09-19 22:09:45 UTC) #2
nweiz
lgtm
6 years, 3 months ago (2014-09-22 20:24:13 UTC) #3
Bob Nystrom
6 years, 3 months ago (2014-09-22 21:08:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698