Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 583193005: Integration of MOVE_FILE into the server and a couple of fixes. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Integration of MOVE_FILE into the server and a couple of fixes. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -3 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringKind.java View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 2 chunks +21 lines, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 2 chunks +34 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-19 17:56:49 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-19 18:10:10 UTC) #2
scheglov
6 years, 3 months ago (2014-09-19 18:11:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698