Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 583053002: pkg/scheduled_test: status tweaks (Closed)

Created:
6 years, 3 months ago by kevmoo
Modified:
6 years, 1 month ago
Reviewers:
ricow1, nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M pkg/pkg.status View 1 chunk +16 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
kevmoo
6 years, 3 months ago (2014-09-19 00:39:48 UTC) #2
nweiz
lgtm https://codereview.chromium.org/583053002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/583053002/diff/1/pkg/pkg.status#newcode243 pkg/pkg.status:243: polymer_expressions/*: Pass, RuntimeError # Issue 19265 Nit, but ...
6 years, 3 months ago (2014-09-19 01:07:20 UTC) #3
kevmoo
https://codereview.chromium.org/583053002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/583053002/diff/1/pkg/pkg.status#newcode243 pkg/pkg.status:243: polymer_expressions/*: Pass, RuntimeError # Issue 19265 On 2014/09/19 01:07:20, ...
6 years, 3 months ago (2014-09-19 01:35:26 UTC) #4
kevmoo
Committed patchset #1 (id:1) manually as 40483 (presubmit successful).
6 years, 3 months ago (2014-09-19 01:36:53 UTC) #5
ricow1
Please don't add so many timeout markers - this effectively increases the cycle time of ...
6 years, 1 month ago (2014-11-14 09:09:45 UTC) #7
kevmoo
6 years, 1 month ago (2014-11-14 18:57:20 UTC) #8
Message was sent while issue was closed.
On 2014/11/14 09:09:45, ricow1 wrote:
> Please don't add so many timeout markers - this effectively increases the
cycle
> time of the windows bots with 8 mins

Understood. The pain with Skip: it doesn't help us track changes or fixes.

Powered by Google App Engine
This is Rietveld 408576698