Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 582673003: Update messages in code transformers now that we have the article about imports. (Closed)

Created:
6 years, 3 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 2 months ago
Reviewers:
Kathy Walrath, jakemac
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update messages in code transformers now that we have the article about imports. R=jakemac@google.com, kathyw@google.com Committed: https://code.google.com/p/dart/source/detail?r=40547

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -241 lines) Patch
M pkg/code_transformers/lib/src/messages.dart View 2 chunks +9 lines, -128 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/generated/messages.html View 2 chunks +9 lines, -110 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Siggi Cherem (dart-lang)
6 years, 3 months ago (2014-09-20 00:48:12 UTC) #2
Kathy Walrath
lgtm
6 years, 3 months ago (2014-09-21 09:29:54 UTC) #3
jakemac
https://codereview.chromium.org/582673003/diff/1/pkg/polymer/pubspec.yaml File pkg/polymer/pubspec.yaml (right): https://codereview.chromium.org/582673003/diff/1/pkg/polymer/pubspec.yaml#newcode14 pkg/polymer/pubspec.yaml:14: code_transformers: '>=0.2.3+1 <0.3.0' I don't know that we really ...
6 years, 3 months ago (2014-09-22 15:14:06 UTC) #4
jakemac
lgtm
6 years, 3 months ago (2014-09-22 15:14:14 UTC) #5
Siggi Cherem (dart-lang)
6 years, 3 months ago (2014-09-22 16:09:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698