Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 582123004: Fix dependencies in pkg.gyp. (Closed)

Created:
6 years, 3 months ago by ahe
Modified:
6 years, 3 months ago
Reviewers:
ricow1, Bob Nystrom
CC:
reviews_dartlang.org, nweiz, Bob Nystrom
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M dart/pkg/pkg.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahe
In GYP, an action cannot have dependencies, but unfortunately GYP doesn't complain about such problems. ...
6 years, 3 months ago (2014-09-19 10:10:59 UTC) #2
ricow1
lgtm, thanks
6 years, 3 months ago (2014-09-19 10:28:52 UTC) #3
ahe
Committed patchset #1 (id:1) manually as 40492 (presubmit successful).
6 years, 3 months ago (2014-09-19 10:29:31 UTC) #4
Bob Nystrom
Nice catch, thanks! I am sorry you have to have gyp expertise, but very grateful ...
6 years, 3 months ago (2014-09-19 18:12:01 UTC) #6
ahe
6 years, 3 months ago (2014-09-20 10:27:22 UTC) #7
Message was sent while issue was closed.
On 2014/09/19 18:12:01, Bob Nystrom wrote:
> I am sorry you have to have gyp expertise, but very grateful that you do!

:-)

Powered by Google App Engine
This is Rietveld 408576698