Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 581793002: Ensure for and if statements have a space after the statement keyword (Closed)

Created:
6 years, 3 months ago by jwren
Modified:
6 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Ensure for and if statements have a space after the statement keyword BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=40403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisErrorFixes.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ChangeContentOverlay.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractLocalVariableFeedback.java View 1 chunk +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodFeedback.java View 1 chunk +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExtractMethodOptions.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditGroup.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/NavigationRegion.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Occurrences.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverrideMember.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceChange.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceFileEdit.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/TypeHierarchyItem.java View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
jwren
6 years, 3 months ago (2014-09-17 21:12:12 UTC) #2
scheglov
LGTM
6 years, 3 months ago (2014-09-17 21:30:42 UTC) #3
jwren
6 years, 3 months ago (2014-09-17 21:31:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40403 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698