Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 58123002: Because drt/dartium wraps tests before running them, the new semantics for how to find and run main… (Closed)

Created:
7 years, 1 month ago by kasperl
Modified:
7 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Because drt/dartium wraps tests before running them, the new semantics for how to find and run main is essentially already implemented there. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M tests/language/language.status View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
7 years, 1 month ago (2013-11-04 18:36:17 UTC) #1
kasperl
TBR'ed to get the Dartium bots to cycle green.
7 years, 1 month ago (2013-11-04 18:37:38 UTC) #2
kasperl
Committed patchset #1 manually as r29833 (presubmit successful).
7 years, 1 month ago (2013-11-04 18:39:29 UTC) #3
kustermann
LGTM Although I'd prefer if we don't introduce new negative tests.
7 years, 1 month ago (2013-11-04 18:42:45 UTC) #4
kasperl
7 years, 1 month ago (2013-11-04 18:44:46 UTC) #5
Message was sent while issue was closed.
I tried briefly to make this work with a multi-test but the imports seemed to be
problematic. Let's discuss how to make these tests better!

Powered by Google App Engine
This is Rietveld 408576698