Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 580273002: Push add*Edit helpers into SourceChange. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Push add*Edit helpers into SourceChange. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -45 lines) Patch
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-18 20:33:53 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-18 20:40:20 UTC) #2
scheglov
6 years, 3 months ago (2014-09-18 21:20:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40464 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698