Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Issue 579913004: Update test so it doens't leave isolates hanging. (Closed)

Created:
6 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 3 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update test so it doens't leave isolates hanging. This caused timeouts on Firefox. Committed: https://code.google.com/p/dart/source/detail?r=40539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M tests/isolate/function_send_test.dart View 4 chunks +9 lines, -7 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
TBR
6 years, 3 months ago (2014-09-22 09:46:26 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 40539 (presubmit successful).
6 years, 3 months ago (2014-09-22 09:47:30 UTC) #3
Søren Gjesse
6 years, 3 months ago (2014-09-22 12:31:51 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698