Issue 57943002: Add fromUri constructor to File, Directory and Link

Issue 57943002: Add fromUri constructor to File, Directory and Link (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add fromUri constructor to File, Directory and Link R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29881

Patch Set 3 : Addressed review commetns #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -1 line)			Patch
M	sdk/lib/io/directory.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
A	tests/standalone/io/directory_uri_test.dart	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	tests/standalone/io/file_uri_test.dart	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	tests/standalone/io/link_uri_test.dart	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://codereview.chromium.org/57943002/diff/40001/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/57943002/diff/40001/sdk/lib/io/directory.dart#newcode23 sdk/lib/io/directory.dart:23: factory Directory.fromUri(Uri uri) => new _Directory.fromUri(uri); Just say ...

7 years, 1 month ago (2013-11-05 08:30:56 UTC) #2

Søren Gjesse

Committed patchset #3 manually as r29881 (presubmit successful).

7 years, 1 month ago (2013-11-05 09:28:18 UTC) #3

Søren Gjesse

7 years, 1 month ago (2013-11-05 09:33:56 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/57943002/diff/40001/sdk/lib/io/directory.dart
File sdk/lib/io/directory.dart (right):

https://codereview.chromium.org/57943002/diff/40001/sdk/lib/io/directory.dart...
sdk/lib/io/directory.dart:23: factory Directory.fromUri(Uri uri) => new
_Directory.fromUri(uri);
On 2013/11/05 08:30:56, Anders Johnsen wrote:
> Just say 'new Directory(uri.toFilePath())' here? Likewise in the other files.

Of cause, done.

https://codereview.chromium.org/57943002/diff/40001/tests/standalone/io/link_...
File tests/standalone/io/link_uri_test.dart (right):

https://codereview.chromium.org/57943002/diff/40001/tests/standalone/io/link_...
tests/standalone/io/link_uri_test.dart:35: Expect.throws(() => new
Link.fromUri(Uri.parse('http://localhost:8080/index.html')),
On 2013/11/05 08:30:56, Anders Johnsen wrote:
> Long line.

Done.

https://codereview.chromium.org/57943002/diff/40001/tests/standalone/io/link_...
tests/standalone/io/link_uri_test.dart:44: //testFromUri();
On 2013/11/05 08:30:56, Anders Johnsen wrote:
> Outcommented.

Done. Also fixed test which was broken.

Expand Messages | Collapse Messages