Issue 579243003: Fixes a bug in CheckClassInstr on arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579243003: Fixes a bug in CheckClassInstr on arm64. (Closed)

Created:
6 years, 3 months ago by zra

Modified:
6 years, 3 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes a bug in CheckClassInstr on arm64. The bug comes from a copy/paste from arm, so I've also renamed the function to be more clear. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40476

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -45 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1	2 chunks	+9 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		13 chunks	+24 lines, -23 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		7 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

https://codereview.chromium.org/579243003/diff/1/runtime/vm/intermediate_language_arm64.cc File runtime/vm/intermediate_language_arm64.cc (right): https://codereview.chromium.org/579243003/diff/1/runtime/vm/intermediate_language_arm64.cc#newcode4931 runtime/vm/intermediate_language_arm64.cc:4931: __ lslv(mask_reg, mask_reg, temp); This was the bug.

6 years, 3 months ago (2014-09-18 16:07:52 UTC) #2

regis

LGTM So, the compiler accepts a Register for an int. I wonder if using int32_t ...

6 years, 3 months ago (2014-09-18 16:38:09 UTC) #3

zra

6 years, 3 months ago (2014-09-18 22:54:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r40476 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages