Issue 579233002: Fix ConstantPropagator::VisitBinaryDoubleOp to work with all integer types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 579233002: Fix ConstantPropagator::VisitBinaryDoubleOp to work with all integer types. (Closed)

Created:
6 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 3 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix ConstantPropagator::VisitBinaryDoubleOp to work with all integer types. R=fschneider@google.com BUG=http://dartbug.com/20984 Committed: https://code.google.com/p/dart/source/detail?r=40433

Patch Set 2 : #

Total comments: 2

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+16 lines, -7 lines	2 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/579233002/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/579233002/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode8515 runtime/vm/flow_graph_optimizer.cc:8515: : Double::Cast(value).value(); Please align : and ?.

6 years, 3 months ago (2014-09-18 12:33:14 UTC) #2

Vyacheslav Egorov (Google)

https://codereview.chromium.org/579233002/diff/20001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/579233002/diff/20001/runtime/vm/flow_graph_optimizer.cc#newcode8515 runtime/vm/flow_graph_optimizer.cc:8515: : Double::Cast(value).value(); On 2014/09/18 12:33:14, Florian Schneider wrote: > ...

6 years, 3 months ago (2014-09-18 12:46:53 UTC) #3

Vyacheslav Egorov (Google)

6 years, 3 months ago (2014-09-18 12:47:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 40433 (presubmit successful).

Expand Messages | Collapse Messages

Issue 579233002: Fix ConstantPropagator::VisitBinaryDoubleOp to work with all integer types. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages