Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 579223003: Set the minimum supported version of Mac OS X when building Dart. (Closed)

Created:
6 years, 3 months ago by Bill Hesse
Modified:
6 years, 3 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Set the minimum supported version of Mac OS X when building Dart. BUG= R=iposva@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gyp/configurations_xcode.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Bill Hesse
Both chromium and v8 define the mac_deployment_target variable, and use it this way. We define ...
6 years, 3 months ago (2014-09-18 12:52:51 UTC) #2
ricow1
lgtm, but let Ivan take a look, I can't remember if there is something special ...
6 years, 3 months ago (2014-09-18 13:09:55 UTC) #3
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-09-18 22:36:07 UTC) #4
Bill Hesse
6 years, 3 months ago (2014-09-19 08:01:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698