convert engine element setter to completion element setter

convert engine element setter to completion element setter

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40362

[danrubel, 2014-09-16 22:36:46]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-09-16 22:47:46]

LGTM

https://codereview.chromium.org/578673002/diff/1/pkg/analysis_server/test/com...
File pkg/analysis_server/test/computer/element_test.dart (right):

https://codereview.chromium.org/578673002/diff/1/pkg/analysis_server/test/com...
pkg/analysis_server/test/computer/element_test.dart:293: findElementInUnit(unit,
'mySetter', engine.ElementKind.FIELD);
The "engine.ElementKind.FIELD" argument looks strange, both because it's there
and because it isn't "engine.ElementKind.SETTER". But I'm not familiar enough
with these tests to know whether it's a problem.

[danrubel, 2014-09-16 23:12:30]

https://codereview.chromium.org/578673002/diff/1/pkg/analysis_server/test/com...
File pkg/analysis_server/test/computer/element_test.dart (right):

https://codereview.chromium.org/578673002/diff/1/pkg/analysis_server/test/com...
pkg/analysis_server/test/computer/element_test.dart:293: findElementInUnit(unit,
'mySetter', engine.ElementKind.FIELD);
On 2014/09/16 22:47:46, Brian Wilkerson wrote:
> The "engine.ElementKind.FIELD" argument looks strange, both because it's there
> and because it isn't "engine.ElementKind.SETTER". But I'm not familiar enough
> with these tests to know whether it's a problem.

I was surprised as well, but my current understanding is that the element model
represents the synthetic field updated by the setter, thus the setter is
attached to and accessed via that field.

[danrubel, 2014-09-16 23:22:02]

Committed patchset #2 (id:20001) manually as 40362 (presubmit successful).