Fix compiler warning:

Fix compiler warning:

[209/7854] CXX obj/dart/runtime/vm/libdart_vm.intermediate_language.o

../../dart/runtime/vm/intermediate_language.cc:1777:45: warning: implicit conversion of NULL constant to 'intptr_t' (aka 'long') [-Wnull-conversion]

        to() == kUnboxedInt32 ? deopt_id_ : NULL);

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40355

[siva, 2014-09-16 18:42:11]

asiva@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2014-09-16 18:55:19]

https://chromiumcodereview.appspot.com/578533003/diff/1/runtime/vm/intermedia...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/578533003/diff/1/runtime/vm/intermedia...
runtime/vm/intermediate_language.cc:1777: to() == (kUnboxedInt32 ? deopt_id_ :
0));
kNoRepresentation?

I do not understand this code. Slava?

[Vyacheslav Egorov (Google), 2014-09-16 18:57:05]

vegorov@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-09-16 18:57:05]

https://codereview.chromium.org/578533003/diff/1/runtime/vm/intermediate_lang...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/578533003/diff/1/runtime/vm/intermediate_lang...
runtime/vm/intermediate_language.cc:1777: to() == (kUnboxedInt32 ? deopt_id_ :
0));
should be 

(to() == kUnboxedInt32) ? deopt_id_ : Isolate::kNoDeoptId.

Thanks for catching this! My compiler does not warn on this obviously incorrect
code for some reason.

[Vyacheslav Egorov (Google), 2014-09-16 18:58:13]

just to give more context: only conversion to Int32 can deoptimize, and thus
needs deopt_id

conversion to Mint is widening -> can't deoptimize
conversion to Uint32 is always a truncation.

[siva, 2014-09-16 19:34:29]

PTAL

[Vyacheslav Egorov (Google), 2014-09-16 19:37:21]

LGTM!

[siva, 2014-09-16 22:50:52]

Committed patchset #2 (id:20001) manually as r40355 (presubmit successful).