Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 57843002: Revert "Search for main in the exported names of the main library, not in the library itself." (Closed)

Created:
7 years, 1 month ago by kasperl
Modified:
7 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Search for main in the exported names of the main library, not in the library itself." This reverts commit 74a865df6d58a87dce5a9d8c77cbc70c694ba50b. TBR'ed. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -72 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 4 chunks +5 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/language/export_ambiguous_main_a.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/export_ambiguous_main_b.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/export_ambiguous_main_negative_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/language/export_double_same_main_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
D tests/language/export_main_override_test.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/language/export_main_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
7 years, 1 month ago (2013-11-04 13:52:56 UTC) #1
kasperl
7 years, 1 month ago (2013-11-04 13:53:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r29808 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698