Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 578213002: Don't use identical for null. (Closed)

Created:
6 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan
Visibility:
Public.

Description

Don't use identical for null. This was just a test to see if it generated the same code (it did), but I forgot to revert it again. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=40432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/lib/integers_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-09-18 08:07:23 UTC) #2
Florian Schneider
Lgtm. Thanks.
6 years, 3 months ago (2014-09-18 09:35:07 UTC) #3
Lasse Reichstein Nielsen
6 years, 3 months ago (2014-09-18 11:56:08 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698