Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 577443003: Save more memory by compacting LocalVarDescriptors (Closed)

Created:
6 years, 3 months ago by hausner
Modified:
6 years, 3 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Save more memory by compacting LocalVarDescriptors (Re-landing this change after assertions fixed.) Instead of allocating an array for the names of local variables, store the names in the LocalVarDescriptors structure directly. Using dart2js to compile a small dart program results in about 7200 LVDs on the heap. Retained memory before: 568KB Retained memory after: 432KB (75%) R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40276

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -45 lines) Patch
M runtime/vm/object.h View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +14 lines, -32 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +20 lines, -4 lines 0 comments Download
M runtime/vm/raw_object.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
hausner
Let's try this again.
6 years, 3 months ago (2014-09-15 21:11:16 UTC) #2
siva
lgtm
6 years, 3 months ago (2014-09-15 21:34:15 UTC) #3
hausner
6 years, 3 months ago (2014-09-15 21:35:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40276 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698