make public the html element names map

make public the html element names map

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40405

[jakemac, 2014-09-17 20:33:33]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2014-09-17 20:45:56]

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:1: #### 0.14.1
add also an entry about your change to make build.dart simpler.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:2: * Make public the map of html tags to html element
class names.
Not sure how much to highlight this, since most polymer users don't care about
this anyways. Maybe it looks less important if we just say 'added
lib/html_element_names.dart'?

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
File pkg/polymer/lib/html_element_names.dart (right):

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:1: library polymer.html_element_names;
+ copyright

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:11: * command, data, dialog, td, th, and
time.
I just checked, it seems that 'dialog' is ok now, we can remove it from here.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:42: 'dialog': 'Element', // see doc
comment, was: 'DialogElement'
and simply change here to 'DialogElement'

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:111: 'template': 'Element', // should be
'TemplateElement', but it is not yet
seems that TemplateElement is in too, let's fix this entry as well

[jakemac, 2014-09-17 21:38:25]

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:1: #### 0.14.1
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> add also an entry about your change to make build.dart simpler.

Done.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/CHANGELOG.md#new...
pkg/polymer/CHANGELOG.md:2: * Make public the map of html tags to html element
class names.
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> Not sure how much to highlight this, since most polymer users don't care about
> this anyways. Maybe it looks less important if we just say 'added
> lib/html_element_names.dart'?

Done, removed the note about it entirely

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
File pkg/polymer/lib/html_element_names.dart (right):

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:1: library polymer.html_element_names;
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> + copyright

Done.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:11: * command, data, dialog, td, th, and
time.
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> I just checked, it seems that 'dialog' is ok now, we can remove it from here.

Done.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:42: 'dialog': 'Element', // see doc
comment, was: 'DialogElement'
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> and simply change here to 'DialogElement'

Done.

https://codereview.chromium.org/576293002/diff/1/pkg/polymer/lib/html_element...
pkg/polymer/lib/html_element_names.dart:111: 'template': 'Element', // should be
'TemplateElement', but it is not yet
On 2014/09/17 20:45:55, Siggi Cherem (dart-lang) wrote:
> seems that TemplateElement is in too, let's fix this entry as well

Done.

[Siggi Cherem (dart-lang), 2014-09-17 21:51:23]

lgtm!

https://codereview.chromium.org/576293002/diff/40001/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/576293002/diff/40001/pkg/polymer/CHANGELOG.md...
pkg/polymer/CHANGELOG.md:7: * Fixed invalid linter warning when using event
handlers inside an
Oh, it seems this one made it before in 0.14.0 :)

[jakemac, 2014-09-17 21:57:19]

https://codereview.chromium.org/576293002/diff/40001/pkg/polymer/CHANGELOG.md
File pkg/polymer/CHANGELOG.md (right):

https://codereview.chromium.org/576293002/diff/40001/pkg/polymer/CHANGELOG.md...
pkg/polymer/CHANGELOG.md:7: * Fixed invalid linter warning when using event
handlers inside an
On 2014/09/17 21:51:22, Siggi Cherem (dart-lang) wrote:
> Oh, it seems this one made it before in 0.14.0 :)

Done.

[jakemac, 2014-09-17 21:58:10]

Committed patchset #4 (id:60001) manually as 40405 (presubmit successful).