Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 575853002: Add tools/ddbg_service. (Closed)

Created:
6 years, 3 months ago by turnidge
Modified:
6 years, 3 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, ricow1, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Add tools/ddbg_service. This is the directory where we will work on a version of ddbg that uses the vm service. Not yet functional. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40334

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add test #

Total comments: 4

Patch Set 4 : code review #

Patch Set 5 : gen js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9294 lines, -8628 lines) Patch
M runtime/bin/vmservice/observatory/deployed/web/index.html_bootstrap.dart.js View 1 2 3 4 860 chunks +4370 lines, -4310 lines 0 comments Download
M runtime/bin/vmservice/observatory/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 4 860 chunks +4370 lines, -4310 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/service_common.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/service_io.dart View 2 chunks +5 lines, -1 line 0 comments Download
A runtime/bin/vmservice/observatory/test/bad_web_socket_address_test.dart View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A tools/ddbg_service/HACKING.txt View 1 1 chunk +17 lines, -0 lines 0 comments Download
A tools/ddbg_service/bin/ddbg_service.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + tools/ddbg_service/lib/commando.dart View 1 2 3 4 chunks +27 lines, -6 lines 0 comments Download
A tools/ddbg_service/lib/debugger.dart View 1 2 3 1 chunk +437 lines, -0 lines 0 comments Download
A + tools/ddbg_service/lib/terminfo.dart View 1 chunk +3 lines, -1 line 0 comments Download
A tools/ddbg_service/pubspec.yaml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
6 years, 3 months ago (2014-09-16 17:26:52 UTC) #2
Cutch
lgtm with some comments https://codereview.chromium.org/575853002/diff/40001/tools/ddbg_service/lib/debugger.dart File tools/ddbg_service/lib/debugger.dart (right): https://codereview.chromium.org/575853002/diff/40001/tools/ddbg_service/lib/debugger.dart#newcode39 tools/ddbg_service/lib/debugger.dart:39: print('Connected to vm'); Should these ...
6 years, 3 months ago (2014-09-16 17:33:37 UTC) #3
turnidge
https://codereview.chromium.org/575853002/diff/40001/tools/ddbg_service/lib/debugger.dart File tools/ddbg_service/lib/debugger.dart (right): https://codereview.chromium.org/575853002/diff/40001/tools/ddbg_service/lib/debugger.dart#newcode39 tools/ddbg_service/lib/debugger.dart:39: print('Connected to vm'); On 2014/09/16 17:33:37, Cutch wrote: > ...
6 years, 3 months ago (2014-09-16 17:52:34 UTC) #4
turnidge
6 years, 3 months ago (2014-09-16 18:16:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 40334 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698