Drop trailing null arguments in generated JS.

Drop trailing null arguments in generated JS.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41555

[herhut, 2014-09-18 13:52:40]

herhut@google.com changed reviewers:
+ floitsch@google.com

[herhut, 2014-09-18 13:55:03]

This had no measurable impact on most benchmarks and showed surprising
improvements for others (e.g. Queens).

It helps significantly with size (about 1.2% on selected applications).

[floitsch, 2014-09-18 13:58:05]

LGTM.
Maybe add a small test?

[floitsch, 2014-09-18 13:58:48]

On 2014/09/18 13:58:05, floitsch wrote:
> LGTM.
> Maybe add a small test?

Scratch the "maybe". We want to have this working after the transition to the
new IR. It should be tested.

[herhut, 2014-09-19 13:19:33]

Patchset #3 (id:40001) has been deleted

[herhut, 2014-09-19 13:23:11]

PTAL

In the long run, we should encode this in calling conventions. The special
renaming in the backend should also be handled using the same mechanism that we
use for DOM bindings.

[floitsch, 2014-09-19 19:28:31]

LGTM.
What test started failing?

[herhut, 2014-09-22 08:29:30]

On 2014/09/19 19:28:31, floitsch wrote:
> LGTM.
> What test started failing?

co19/LibTest/async/Stream/expand_A01_t01
co19/LibTest/collection/DoubleLinkedQueue/DoubleLinkedQueue_class_A01_t01
co19/LibTest/collection/DoubleLinkedQueue/toList_A01_t02
co19/LibTest/collection/HashSet/HashSet_class_A01_t01
co19/LibTest/collection/IterableBase/IterableBase_class_A01_t02
co19/LibTest/collection/LinkedHashSet/LinkedHashSet_class_A01_t01
co19/LibTest/collection/ListQueue/ListQueue_class_A01_t01
co19/LibTest/collection/Queue/Queue_class_A01_t01
co19/LibTest/core/List/List.from_A01_t02
co19/LibTest/core/Set/IterableBase_A01_t01
co19/LibTest/isolate/ReceivePort/expand_A01_t01
corelib/json_map_test

[herhut, 2014-09-22 11:50:30]

herhut@google.com changed reviewers:
+ sra@google.com

[herhut, 2014-09-22 11:51:50]

I have decided to disable this for native functions just to be on the safe side.
I am not aware of a native function that does require all arguments to be passed
but we probably should have an annotation for this and look at them in detail.

[sra1, 2014-10-24 23:32:00]

https://codereview.chromium.org/575013002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/575013002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:476: *
'arguments.lenght' in JavaScript, [allArgsRequired] should be set to
`arguments.length`

https://codereview.chromium.org/575013002/diff/60001/tests/compiler/dart2js/d...
File tests/compiler/dart2js/drop_trailing_null_arguments_test.dart (right):

https://codereview.chromium.org/575013002/diff/60001/tests/compiler/dart2js/d...
tests/compiler/dart2js/drop_trailing_null_arguments_test.dart:27:
print(generated);
Remove debug print

[herhut, 2014-11-06 13:14:44]

https://codereview.chromium.org/575013002/diff/60001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/575013002/diff/60001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:476: *
'arguments.lenght' in JavaScript, [allArgsRequired] should be set to
On 2014/10/24 23:31:59, sra1 wrote:
> `arguments.length`

Done.

https://codereview.chromium.org/575013002/diff/60001/tests/compiler/dart2js/d...
File tests/compiler/dart2js/drop_trailing_null_arguments_test.dart (right):

https://codereview.chromium.org/575013002/diff/60001/tests/compiler/dart2js/d...
tests/compiler/dart2js/drop_trailing_null_arguments_test.dart:27:
print(generated);
On 2014/10/24 23:32:00, sra1 wrote:
> Remove debug print

Done.

[herhut, 2014-11-06 13:19:05]

Committed patchset #5 (id:100001) manually as 41555 (presubmit successful).