Add tools/download_file.dart helper + download_contentshell shell/bat script included in the editor…

Add tools/download_file.dart helper + download_contentshell shell/bat script included in the editor zip files.

BUG=
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29902

[kustermann, 2013-11-04 16:36:51]

I'll still need to test it on windows.

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.py
File dart/editor/build/build.py (right):

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.p...
dart/editor/build/build.py:1020: % (CHANNEL, contentshell_name))
I'm not sure if we should use 'latest' here or the exact revision.

[ricow1, 2013-11-04 17:14:52]

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.py
File dart/editor/build/build.py (right):

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.p...
dart/editor/build/build.py:975: REM This script will download content shell to
"content_shell.zip" in the
why don't we just put these scripts inside tools/dartium as well?

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.p...
dart/editor/build/build.py:1020: % (CHANNEL, contentshell_name))
On 2013/11/04 16:36:52, kustermann wrote:
> I'm not sure if we should use 'latest' here or the exact revision.

We should use the exact version, otherwise there can be subtle differences
between what users are seeing in their dartium and what their testing scripts
are reporting

[kustermann, 2013-11-05 12:45:19]

PTAL, I'll do some simple tests on windows now.

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.py
File dart/editor/build/build.py (right):

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.p...
dart/editor/build/build.py:975: REM This script will download content shell to
"content_shell.zip" in the
On 2013/11/04 17:14:53, ricow1 wrote:
> why don't we just put these scripts inside tools/dartium as well?

We could, but remember that these are not executable scripts, since we patch
them with the URL / filename.

I'll change it.

https://codereview.chromium.org/57483005/diff/20001/dart/editor/build/build.p...
dart/editor/build/build.py:1020: % (CHANNEL, contentshell_name))
On 2013/11/04 17:14:53, ricow1 wrote:
> On 2013/11/04 16:36:52, kustermann wrote:
> > I'm not sure if we should use 'latest' here or the exact revision.
> 
> We should use the exact version, otherwise there can be subtle differences
> between what users are seeing in their dartium and what their testing scripts
> are reporting

I'll change it.

[ricow1, 2013-11-05 12:59:33]

LGTM

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build.py
File dart/editor/build/build.py (right):

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build....
dart/editor/build/build.py:970: def
instantiate_download_script_template(destination, replacements):
please add a comment describing what this does, it is pretty hard to follow,
something like
""" Fixes up the script we use for downloading so that it points to the correct
url and downloads this tool into the correct location. """

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build....
dart/editor/build/build.py:1019:
("http://dartlang.org/editor/update/channels/%s/%s/dartium/%s"
should we do a namer for this?

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
File dart/tools/dartium/download_file.dart (right):

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
dart/tools/dartium/download_file.dart:30: note(String message) {
remove and just use print

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
File dart/tools/dartium/download_shellscript_template.bat (right):

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
dart/tools/dartium/download_shellscript_template.bat:1: REM This script will
download VAR_DOWNLOAD_URL to VAR_DESTINATION in the current
copyright header

[kustermann, 2013-11-05 13:11:05]

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build.py
File dart/editor/build/build.py (right):

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build....
dart/editor/build/build.py:970: def
instantiate_download_script_template(destination, replacements):
On 2013/11/05 12:59:33, ricow1 wrote:
> please add a comment describing what this does, it is pretty hard to follow,
> something like
> """ Fixes up the script we use for downloading so that it points to the
correct
> url and downloads this tool into the correct location. """

Done.

https://codereview.chromium.org/57483005/diff/100001/dart/editor/build/build....
dart/editor/build/build.py:1019:
("http://dartlang.org/editor/update/channels/%s/%s/dartium/%s"
On 2013/11/05 12:59:33, ricow1 wrote:
> should we do a namer for this?

We can do it in another CL.

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
File dart/tools/dartium/download_file.dart (right):

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
dart/tools/dartium/download_file.dart:30: note(String message) {
On 2013/11/05 12:59:33, ricow1 wrote:
> remove and just use print

Done.

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
File dart/tools/dartium/download_shellscript_template.bat (right):

https://codereview.chromium.org/57483005/diff/100001/dart/tools/dartium/downl...
dart/tools/dartium/download_shellscript_template.bat:1: REM This script will
download VAR_DOWNLOAD_URL to VAR_DESTINATION in the current
On 2013/11/05 12:59:33, ricow1 wrote:
> copyright header

Done.

[kustermann, 2013-11-05 13:11:54]

Committed patchset #4 manually as r29902 (presubmit successful).