Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 574443002: Update NSS to 3.16.4. Updated to Chromium's copy of NSS at revision 291806 (Closed)

Created:
6 years, 3 months ago by Bill Hesse
Modified:
6 years, 3 months ago
Reviewers:
ricow1, zra, Søren Gjesse
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Update NSS to 3.16.4. Updated to Chromium's copy of NSS at revision 291806 Includes a fix for an Android L issue. R=ricow@google.com, sgjesse@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=40430

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -83 lines) Patch
M dart/runtime/bin/net/nss.gyp View 1 2 3 4 5 13 chunks +39 lines, -34 lines 0 comments Download
M dart/runtime/bin/net/nss_memio.h View 1 2 3 4 5 2 chunks +7 lines, -6 lines 0 comments Download
M dart/runtime/bin/net/nss_memio.cc View 1 2 3 4 5 2 chunks +6 lines, -2 lines 0 comments Download
M dart/runtime/bin/net/sqlite.gyp View 1 2 3 4 5 3 chunks +9 lines, -15 lines 0 comments Download
M dart/runtime/bin/net/ssl.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/bin/net/zlib.gyp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/bin/secure_socket.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M deps/all.deps/DEPS View 1 2 3 4 5 5 chunks +25 lines, -12 lines 0 comments Download
M deps/standalone.deps/DEPS View 3 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bill Hesse
6 years, 3 months ago (2014-09-15 14:33:19 UTC) #2
zra
lgtm
6 years, 3 months ago (2014-09-15 15:33:58 UTC) #3
zra
On 2014/09/15 15:33:58, zra wrote: > lgtm And thanks!
6 years, 3 months ago (2014-09-15 15:34:11 UTC) #4
Søren Gjesse
lgtm
6 years, 3 months ago (2014-09-16 07:49:48 UTC) #5
Bill Hesse
Ricow, PTAL at the DEPS changes. The rest is unchanged. Ivan, standalone.deps is updated to ...
6 years, 3 months ago (2014-09-18 08:56:05 UTC) #7
ricow1
lgtm
6 years, 3 months ago (2014-09-18 09:15:32 UTC) #8
Bill Hesse
6 years, 3 months ago (2014-09-18 10:40:53 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as r40430.

Powered by Google App Engine
This is Rietveld 408576698