Issue 57433004: Re-land "Search for main in the exported names of the main library, not in the library itself."

Issue 57433004: Re-land "Search for main in the exported names of the main library, not in the library itself." (Closed)

Created:
7 years, 1 month ago by kasperl

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-land "Search for main in the exported names of the main library, not in the library itself." BUG= Committed: https://code.google.com/p/dart/source/detail?r=29812

Patch Set 1 #

Patch Set 2 : Fix package1 test. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -18 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		4 chunks	+12 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/language/export_ambiguous_main_a.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	tests/language/export_ambiguous_main_b.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	tests/language/export_ambiguous_main_negative_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	tests/language/export_double_same_main_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	tests/language/export_main_override_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A +	tests/language/export_main_test.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/package/package1_test.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #2 manually as r29812 (presubmit successful).

7 years, 1 month ago (2013-11-04 15:41:18 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages