Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 574213002: Estimate quotient digit in Bigint division using an integer division instead of (Closed)

Created:
6 years, 3 months ago by regis
Modified:
6 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Estimate quotient digit in Bigint division using an integer division instead of a floating point division. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40365

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -20 lines) Patch
M runtime/lib/bigint.dart View 1 5 chunks +18 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
regis
6 years, 3 months ago (2014-09-17 00:17:39 UTC) #2
srdjan
lgtm
6 years, 3 months ago (2014-09-17 00:31:09 UTC) #3
regis
On 2014/09/17 00:31:09, srdjan wrote: > lgtm Although all the tests pass, I need to ...
6 years, 3 months ago (2014-09-17 00:36:48 UTC) #4
regis
On 2014/09/17 00:36:48, regis wrote: > On 2014/09/17 00:31:09, srdjan wrote: > > lgtm > ...
6 years, 3 months ago (2014-09-17 01:44:20 UTC) #5
regis
6 years, 3 months ago (2014-09-17 01:44:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r40365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698