Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 57383007: Issue 14452. Fix for skipping 'final' modifier in function expression parameters. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Issue 14452. Fix for skipping 'final' modifier in function expression parameters. https://code.google.com/p/dart/issues/detail?id=14452 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +9 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java View 1 chunk +13 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 1 month ago (2013-11-04 18:56:32 UTC) #1
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-11-04 18:59:34 UTC) #2
scheglov
7 years, 1 month ago (2013-11-04 19:13:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29838 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698