Issue 57383006: Avoid redundant assertion code in equality comparisons in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57383006: Avoid redundant assertion code in equality comparisons in checked mode. (Closed)

Created:
7 years, 1 month ago by fschneider

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Avoid redundant assertion code in equality comparisons in checked mode. The result of an equality operation only needs to be checked if it is negated. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29964

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Florian Schneider

This is a left-over from changing the IL for ==.

7 years, 1 month ago (2013-11-04 17:47:14 UTC) #1

fschneider

7 years, 1 month ago (2013-11-06 11:02:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29964 (presubmit successful).