Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 57373007: Change status of corelib/map_values2_test. (Closed)

Created:
7 years, 1 month ago by karlklose
Modified:
7 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change status of corelib/map_values2_test. On dart2js, the library function to create the values-iterable uses IterableBase.map, which create a MappedIterable where the second type argument is set to dynamic. As a consequence, the result of `get values` is an Iterable<dynamic>. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib/corelib.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 1 month ago (2013-11-04 15:40:40 UTC) #1
floitsch
LGTM.
7 years, 1 month ago (2013-11-04 18:25:08 UTC) #2
karlklose
7 years, 1 month ago (2013-11-05 07:16:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698